浏览代码

netfilter: x_tables: Add note about how to free percpu counters

Due to the way percpu counters are allocated and freed in blocks,
it is not safe to free counters individually.  Currently all callers
do the right thing, but let's note this restriction.

Fixes: ae0ac0ed6fcf ("netfilter: x_tables: pack percpu counter allocations")
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Ben Hutchings 7 年之前
父节点
当前提交
9ba5c404bf
共有 1 个文件被更改,包括 3 次插入1 次删除
  1. 3 1
      net/netfilter/x_tables.c

+ 3 - 1
net/netfilter/x_tables.c

@@ -1854,7 +1854,9 @@ EXPORT_SYMBOL_GPL(xt_proto_fini);
  * to fetch the real percpu counter.
  * to fetch the real percpu counter.
  *
  *
  * To speed up allocation and improve data locality, a 4kb block is
  * To speed up allocation and improve data locality, a 4kb block is
- * allocated.
+ * allocated.  Freeing any counter may free an entire block, so all
+ * counters allocated using the same state must be freed at the same
+ * time.
  *
  *
  * xt_percpu_counter_alloc_state contains the base address of the
  * xt_percpu_counter_alloc_state contains the base address of the
  * allocated page and the current sub-offset.
  * allocated page and the current sub-offset.