ソースを参照

serial: ifx6x60: Remove dangerous spi_driver casts

Casting spi_driver pointers to "void *" when calling
spi_{,un}register_driver() bypasses all type checking.

Remove the superfluous casts to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven 10 年 前
コミット
9a499db032
1 ファイル変更3 行追加3 行削除
  1. 3 3
      drivers/tty/serial/ifx6x60.c

+ 3 - 3
drivers/tty/serial/ifx6x60.c

@@ -1381,7 +1381,7 @@ static void __exit ifx_spi_exit(void)
 	/* unregister */
 	/* unregister */
 	tty_unregister_driver(tty_drv);
 	tty_unregister_driver(tty_drv);
 	put_tty_driver(tty_drv);
 	put_tty_driver(tty_drv);
-	spi_unregister_driver((void *)&ifx_spi_driver);
+	spi_unregister_driver(&ifx_spi_driver);
 	unregister_reboot_notifier(&ifx_modem_reboot_notifier_block);
 	unregister_reboot_notifier(&ifx_modem_reboot_notifier_block);
 }
 }
 
 
@@ -1420,7 +1420,7 @@ static int __init ifx_spi_init(void)
 		goto err_free_tty;
 		goto err_free_tty;
 	}
 	}
 
 
-	result = spi_register_driver((void *)&ifx_spi_driver);
+	result = spi_register_driver(&ifx_spi_driver);
 	if (result) {
 	if (result) {
 		pr_err("%s: spi_register_driver failed(%d)",
 		pr_err("%s: spi_register_driver failed(%d)",
 			DRVNAME, result);
 			DRVNAME, result);
@@ -1436,7 +1436,7 @@ static int __init ifx_spi_init(void)
 
 
 	return 0;
 	return 0;
 err_unreg_spi:
 err_unreg_spi:
-	spi_unregister_driver((void *)&ifx_spi_driver);
+	spi_unregister_driver(&ifx_spi_driver);
 err_unreg_tty:
 err_unreg_tty:
 	tty_unregister_driver(tty_drv);
 	tty_unregister_driver(tty_drv);
 err_free_tty:
 err_free_tty: