|
@@ -388,7 +388,7 @@ static int tw9910_set_hsync(struct i2c_client *client)
|
|
|
if (ret < 0)
|
|
|
return ret;
|
|
|
|
|
|
- /* So far only revisions 0 and 1 have been seen */
|
|
|
+ /* So far only revisions 0 and 1 have been seen. */
|
|
|
/* bit 2 - 0 */
|
|
|
if (priv->revision == 1)
|
|
|
ret = tw9910_mask_set(client, HSLOWCTL, 0x77,
|
|
@@ -653,21 +653,15 @@ static int tw9910_set_frame(struct v4l2_subdev *sd, u32 *width, u32 *height)
|
|
|
int ret = -EINVAL;
|
|
|
u8 val;
|
|
|
|
|
|
- /*
|
|
|
- * select suitable norm
|
|
|
- */
|
|
|
+ /* Select suitable norm. */
|
|
|
priv->scale = tw9910_select_norm(priv->norm, *width, *height);
|
|
|
if (!priv->scale)
|
|
|
goto tw9910_set_fmt_error;
|
|
|
|
|
|
- /*
|
|
|
- * reset hardware
|
|
|
- */
|
|
|
+ /* Reset hardware. */
|
|
|
tw9910_reset(client);
|
|
|
|
|
|
- /*
|
|
|
- * set bus width
|
|
|
- */
|
|
|
+ /* Set bus width. */
|
|
|
val = 0x00;
|
|
|
if (priv->info->buswidth == 16)
|
|
|
val = LEN;
|
|
@@ -676,9 +670,7 @@ static int tw9910_set_frame(struct v4l2_subdev *sd, u32 *width, u32 *height)
|
|
|
if (ret < 0)
|
|
|
goto tw9910_set_fmt_error;
|
|
|
|
|
|
- /*
|
|
|
- * select MPOUT behavior
|
|
|
- */
|
|
|
+ /* Select MPOUT behavior. */
|
|
|
switch (priv->info->mpout) {
|
|
|
case TW9910_MPO_VLOSS:
|
|
|
val = RTSEL_VLOSS; break;
|
|
@@ -704,16 +696,12 @@ static int tw9910_set_frame(struct v4l2_subdev *sd, u32 *width, u32 *height)
|
|
|
if (ret < 0)
|
|
|
goto tw9910_set_fmt_error;
|
|
|
|
|
|
- /*
|
|
|
- * set scale
|
|
|
- */
|
|
|
+ /* Set scale. */
|
|
|
ret = tw9910_set_scale(client, priv->scale);
|
|
|
if (ret < 0)
|
|
|
goto tw9910_set_fmt_error;
|
|
|
|
|
|
- /*
|
|
|
- * set hsync
|
|
|
- */
|
|
|
+ /* Set hsync. */
|
|
|
ret = tw9910_set_hsync(client);
|
|
|
if (ret < 0)
|
|
|
goto tw9910_set_fmt_error;
|
|
@@ -740,7 +728,7 @@ static int tw9910_get_selection(struct v4l2_subdev *sd,
|
|
|
|
|
|
if (sel->which != V4L2_SUBDEV_FORMAT_ACTIVE)
|
|
|
return -EINVAL;
|
|
|
- /* Only CROP, CROP_DEFAULT and CROP_BOUNDS are supported */
|
|
|
+ /* Only CROP, CROP_DEFAULT and CROP_BOUNDS are supported. */
|
|
|
if (sel->target > V4L2_SEL_TGT_CROP_BOUNDS)
|
|
|
return -EINVAL;
|
|
|
|
|
@@ -791,9 +779,7 @@ static int tw9910_s_fmt(struct v4l2_subdev *sd,
|
|
|
WARN_ON(mf->field != V4L2_FIELD_ANY &&
|
|
|
mf->field != V4L2_FIELD_INTERLACED_BT);
|
|
|
|
|
|
- /*
|
|
|
- * check color format
|
|
|
- */
|
|
|
+ /* Check color format. */
|
|
|
if (mf->code != MEDIA_BUS_FMT_UYVY8_2X8)
|
|
|
return -EINVAL;
|
|
|
|
|
@@ -829,9 +815,7 @@ static int tw9910_set_fmt(struct v4l2_subdev *sd,
|
|
|
mf->code = MEDIA_BUS_FMT_UYVY8_2X8;
|
|
|
mf->colorspace = V4L2_COLORSPACE_SMPTE170M;
|
|
|
|
|
|
- /*
|
|
|
- * select suitable norm
|
|
|
- */
|
|
|
+ /* Select suitable norm. */
|
|
|
scale = tw9910_select_norm(priv->norm, mf->width, mf->height);
|
|
|
if (!scale)
|
|
|
return -EINVAL;
|
|
@@ -851,9 +835,7 @@ static int tw9910_video_probe(struct i2c_client *client)
|
|
|
s32 id;
|
|
|
int ret;
|
|
|
|
|
|
- /*
|
|
|
- * tw9910 only use 8 or 16 bit bus width
|
|
|
- */
|
|
|
+ /* TW9910 only use 8 or 16 bit bus width. */
|
|
|
if (priv->info->buswidth != 16 && priv->info->buswidth != 8) {
|
|
|
dev_err(&client->dev, "bus width error\n");
|
|
|
return -ENODEV;
|
|
@@ -864,8 +846,8 @@ static int tw9910_video_probe(struct i2c_client *client)
|
|
|
return ret;
|
|
|
|
|
|
/*
|
|
|
- * check and show Product ID
|
|
|
- * So far only revisions 0 and 1 have been seen
|
|
|
+ * Check and show Product ID.
|
|
|
+ * So far only revisions 0 and 1 have been seen.
|
|
|
*/
|
|
|
id = i2c_smbus_read_byte_data(client, ID);
|
|
|
priv->revision = GET_REV(id);
|