Browse Source

tty: Improve tty_debug() macro

Incorporate suggestions for tty core debug macro improvements
 - printk(KERN_DEBUG) => pr_debug()
 - ##args => ##__VA_ARGS__
 - remove do {} while()
 - output tty_name() first

cc: Joe Perches <joe@perches.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Hurley 9 years ago
parent
commit
998b4a4571
1 changed files with 2 additions and 5 deletions
  1. 2 5
      include/linux/tty.h

+ 2 - 5
include/linux/tty.h

@@ -667,10 +667,7 @@ static inline void proc_tty_register_driver(struct tty_driver *d) {}
 static inline void proc_tty_unregister_driver(struct tty_driver *d) {}
 #endif
 
-#define tty_debug(tty, f, args...)					\
-	do {								\
-		printk(KERN_DEBUG "%s: %s: " f, __func__,		\
-		       tty_name(tty), ##args);				\
-	} while (0)
+#define tty_debug(tty, f, ...) \
+	pr_debug("%s: %s: " f, tty_name(tty), __func__, ##__VA_ARGS__)
 
 #endif