浏览代码

[media] media: usb: cpia2: Use kmemdup instead of kmalloc and memcpy

When some other buffer is immediately copied into allocated region.
Replace calls to kmalloc followed by a memcpy with a direct
call to kmemdup.

Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Shyam Saini 8 年之前
父节点
当前提交
9945cf9997
共有 1 个文件被更改,包括 1 次插入3 次删除
  1. 1 3
      drivers/media/usb/cpia2/cpia2_usb.c

+ 1 - 3
drivers/media/usb/cpia2/cpia2_usb.c

@@ -547,12 +547,10 @@ static int write_packet(struct usb_device *udev,
 	if (!registers || size <= 0)
 	if (!registers || size <= 0)
 		return -EINVAL;
 		return -EINVAL;
 
 
-	buf = kmalloc(size, GFP_KERNEL);
+	buf = kmemdup(registers, size, GFP_KERNEL);
 	if (!buf)
 	if (!buf)
 		return -ENOMEM;
 		return -ENOMEM;
 
 
-	memcpy(buf, registers, size);
-
 	ret = usb_control_msg(udev,
 	ret = usb_control_msg(udev,
 			       usb_sndctrlpipe(udev, 0),
 			       usb_sndctrlpipe(udev, 0),
 			       request,
 			       request,