瀏覽代碼

PCI: dra7xx: Fix return value in case of error

In dra7xx_pcie_init_irq_domain(), the pattern used to check and return
error is:

   if (!var) {
      dev_err(...);
      return PTR_ERR(var);
   }

So the returned value in case of error is always 0, which means 'success'.
Change it to return -ENODEV instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
Christophe JAILLET 9 年之前
父節點
當前提交
991bfef82f
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/pci/host/pci-dra7xx.c

+ 2 - 2
drivers/pci/host/pci-dra7xx.c

@@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
 
 
 	if (!pcie_intc_node) {
 	if (!pcie_intc_node) {
 		dev_err(dev, "No PCIe Intc node found\n");
 		dev_err(dev, "No PCIe Intc node found\n");
-		return PTR_ERR(pcie_intc_node);
+		return -ENODEV;
 	}
 	}
 
 
 	pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
 	pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
 					       &intx_domain_ops, pp);
 					       &intx_domain_ops, pp);
 	if (!pp->irq_domain) {
 	if (!pp->irq_domain) {
 		dev_err(dev, "Failed to get a INTx IRQ domain\n");
 		dev_err(dev, "Failed to get a INTx IRQ domain\n");
-		return PTR_ERR(pp->irq_domain);
+		return -ENODEV;
 	}
 	}
 
 
 	return 0;
 	return 0;