浏览代码

x86/efi: Store upper bits of command line buffer address in ext_cmd_line_ptr

Until now, the EFI stub was only setting the 32 bit cmd_line_ptr in
the setup_header structure, so on 64 bit platforms this could be truncated.
This patch adds setting the upper bits of the buffer address in
ext_cmd_line_ptr.  This case was likely never hit, as the allocation
for this buffer is done at the lowest available address.  Only
x86_64 kernels have this problem, as the 1-1 mapping mandated
by EFI ensures that all memory is 32 bit addressable on 32 bit
platforms.  The EFI stub does not support mixed mode, so the
32 bit kernel on 64 bit firmware case does not need to be handled.

Signed-off-by: Roy Franz <roy.franz@linaro.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Roy Franz 10 年之前
父节点
当前提交
98b228f550
共有 1 个文件被更改,包括 2 次插入0 次删除
  1. 2 0
      arch/x86/boot/compressed/eboot.c

+ 2 - 0
arch/x86/boot/compressed/eboot.c

@@ -1110,6 +1110,8 @@ struct boot_params *make_boot_params(struct efi_config *c)
 	if (!cmdline_ptr)
 	if (!cmdline_ptr)
 		goto fail;
 		goto fail;
 	hdr->cmd_line_ptr = (unsigned long)cmdline_ptr;
 	hdr->cmd_line_ptr = (unsigned long)cmdline_ptr;
+	/* Fill in upper bits of command line address, NOP on 32 bit  */
+	boot_params->ext_cmd_line_ptr = (u64)(unsigned long)cmdline_ptr >> 32;
 
 
 	hdr->ramdisk_image = 0;
 	hdr->ramdisk_image = 0;
 	hdr->ramdisk_size = 0;
 	hdr->ramdisk_size = 0;