Browse Source

btrfs: check_int: propagate out-of-memory error upwards

This issue was not causing any harm but IMO (and in the opinion of the
static code checker) it is better to propagate this error status upwards.

Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>
Stefan Behrens 11 years ago
parent
commit
98806b446d
1 changed files with 4 additions and 1 deletions
  1. 4 1
      fs/btrfs/check-integrity.c

+ 4 - 1
fs/btrfs/check-integrity.c

@@ -1093,6 +1093,7 @@ leaf_item_out_of_bounce_error:
 					next_stack =
 					next_stack =
 					    btrfsic_stack_frame_alloc();
 					    btrfsic_stack_frame_alloc();
 					if (NULL == next_stack) {
 					if (NULL == next_stack) {
+						sf->error = -1;
 						btrfsic_release_block_ctx(
 						btrfsic_release_block_ctx(
 								&sf->
 								&sf->
 								next_block_ctx);
 								next_block_ctx);
@@ -1190,8 +1191,10 @@ continue_with_current_node_stack_frame:
 				    sf->next_block_ctx.datav[0];
 				    sf->next_block_ctx.datav[0];
 
 
 				next_stack = btrfsic_stack_frame_alloc();
 				next_stack = btrfsic_stack_frame_alloc();
-				if (NULL == next_stack)
+				if (NULL == next_stack) {
+					sf->error = -1;
 					goto one_stack_frame_backwards;
 					goto one_stack_frame_backwards;
+				}
 
 
 				next_stack->i = -1;
 				next_stack->i = -1;
 				next_stack->block = sf->next_block;
 				next_stack->block = sf->next_block;