瀏覽代碼

cpufreq: Do not allow ->setpolicy drivers to provide ->target

cpufreq drivers that provide the ->setpolicy() callback are supposed
to have integrated governors, so they don't need to set ->target()
or ->target_index() and may confuse the core if any of these callbacks
is present.

For this reason, add a check preventing ->setpolicy cpufreq drivers
from registering if they have non-NULL ->target or ->target_index.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Rafael J. Wysocki 11 年之前
父節點
當前提交
9832235f3f
共有 1 個文件被更改,包括 3 次插入1 次删除
  1. 3 1
      drivers/cpufreq/cpufreq.c

+ 3 - 1
drivers/cpufreq/cpufreq.c

@@ -2299,7 +2299,9 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
 
 
 	if (!driver_data || !driver_data->verify || !driver_data->init ||
 	if (!driver_data || !driver_data->verify || !driver_data->init ||
 	    !(driver_data->setpolicy || driver_data->target_index ||
 	    !(driver_data->setpolicy || driver_data->target_index ||
-		    driver_data->target))
+		    driver_data->target) ||
+	     (driver_data->setpolicy && (driver_data->target_index ||
+		    driver_data->target)))
 		return -EINVAL;
 		return -EINVAL;
 
 
 	pr_debug("trying to register driver %s\n", driver_data->name);
 	pr_debug("trying to register driver %s\n", driver_data->name);