Browse Source

ovl: allow zero size xattr

When ovl_copy_xattr() encountered a zero size xattr no more xattrs were
copied and the function returned success.  This is clearly not the desired
behavior.

Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Cc: <stable@vger.kernel.org>
Miklos Szeredi 9 years ago
parent
commit
97daf8b97a
1 changed files with 1 additions and 1 deletions
  1. 1 1
      fs/overlayfs/copy_up.c

+ 1 - 1
fs/overlayfs/copy_up.c

@@ -54,7 +54,7 @@ int ovl_copy_xattr(struct dentry *old, struct dentry *new)
 
 
 	for (name = buf; name < (buf + list_size); name += strlen(name) + 1) {
 	for (name = buf; name < (buf + list_size); name += strlen(name) + 1) {
 		size = vfs_getxattr(old, name, value, XATTR_SIZE_MAX);
 		size = vfs_getxattr(old, name, value, XATTR_SIZE_MAX);
-		if (size <= 0) {
+		if (size < 0) {
 			error = size;
 			error = size;
 			goto out_free_value;
 			goto out_free_value;
 		}
 		}