Browse Source

f2fs: remove a redundant conditional expression

Avoid checking is_inode repeatedly, and make the logic
a little bit clearer.

Signed-off-by: Fan li <fanofcode.li@samsung.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
LiFan 7 years ago
parent
commit
979f492fe3
1 changed files with 4 additions and 4 deletions
  1. 4 4
      fs/f2fs/f2fs.h

+ 4 - 4
fs/f2fs/f2fs.h

@@ -1996,11 +1996,11 @@ static inline block_t datablock_addr(struct inode *inode,
 	raw_node = F2FS_NODE(node_page);
 	raw_node = F2FS_NODE(node_page);
 
 
 	/* from GC path only */
 	/* from GC path only */
-	if (!inode) {
-		if (is_inode)
+	if (is_inode) {
+		if (!inode)
 			base = offset_in_addr(&raw_node->i);
 			base = offset_in_addr(&raw_node->i);
-	} else if (f2fs_has_extra_attr(inode) && is_inode) {
-		base = get_extra_isize(inode);
+		else if (f2fs_has_extra_attr(inode))
+			base = get_extra_isize(inode);
 	}
 	}
 
 
 	addr_array = blkaddr_in_node(raw_node);
 	addr_array = blkaddr_in_node(raw_node);