Browse Source

usb: dwc2: debugfs: Don't touch RX FIFO during register dump

Dumping the registers via debugfs makes USB on Raspberry Pi completely
unusable. The read of register GRXSTSP ("Receive Status Read and Pop
Register") is responsible for this behaviour, because it pops the RX FIFO.
So avoid this by omitting the relevant register.

CC: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>
Fixes: 563cf017c443 ("usb: dwc2: debugfs: add support for complete register dump")
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Stefan Wahren 7 years ago
parent
commit
971b750d31
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/usb/dwc2/debugfs.c

+ 1 - 1
drivers/usb/dwc2/debugfs.c

@@ -368,7 +368,7 @@ static const struct debugfs_reg32 dwc2_regs[] = {
 	dump_register(GINTSTS),
 	dump_register(GINTSTS),
 	dump_register(GINTMSK),
 	dump_register(GINTMSK),
 	dump_register(GRXSTSR),
 	dump_register(GRXSTSR),
-	dump_register(GRXSTSP),
+	/* Omit GRXSTSP */
 	dump_register(GRXFSIZ),
 	dump_register(GRXFSIZ),
 	dump_register(GNPTXFSIZ),
 	dump_register(GNPTXFSIZ),
 	dump_register(GNPTXSTS),
 	dump_register(GNPTXSTS),