瀏覽代碼

eeprom: at25: Fix SPI device leak

The at25 driver is using spi_dev_get() apparently just to take a copy
of the SPI device used to instantiate it but never calls spi_dev_put()
to free it.  Since the device is guaranteed to exist between probe() and
remove() there should be no need for the driver to take an extra
reference to it so fix the leak by just using a straight assignment.

Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Brown 9 年之前
父節點
當前提交
96b2a45c66
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/misc/eeprom/at25.c

+ 1 - 1
drivers/misc/eeprom/at25.c

@@ -345,7 +345,7 @@ static int at25_probe(struct spi_device *spi)
 
 
 	mutex_init(&at25->lock);
 	mutex_init(&at25->lock);
 	at25->chip = chip;
 	at25->chip = chip;
-	at25->spi = spi_dev_get(spi);
+	at25->spi = spi;
 	spi_set_drvdata(spi, at25);
 	spi_set_drvdata(spi, at25);
 	at25->addrlen = addrlen;
 	at25->addrlen = addrlen;