Эх сурвалжийг харах

amd-xgbe: Use system workqueue for device restart

A previous patch switched from using the system workqueue to the device
workqueue for various operations. During a device restart the device
workqueue is flushed so the restart cannot use this workqueue or else
a deadlock results.  Move the device restart back to using the system
workqueue.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Lendacky, Thomas 9 жил өмнө
parent
commit
96aec91148

+ 2 - 2
drivers/net/ethernet/amd/xgbe/xgbe-drv.c

@@ -365,7 +365,7 @@ static irqreturn_t xgbe_isr(int irq, void *data)
 
 
 		/* Restart the device on a Fatal Bus Error */
 		/* Restart the device on a Fatal Bus Error */
 		if (XGMAC_GET_BITS(dma_ch_isr, DMA_CH_SR, FBE))
 		if (XGMAC_GET_BITS(dma_ch_isr, DMA_CH_SR, FBE))
-			queue_work(pdata->dev_workqueue, &pdata->restart_work);
+			schedule_work(&pdata->restart_work);
 
 
 		/* Clear all interrupt signals */
 		/* Clear all interrupt signals */
 		XGMAC_DMA_IOWRITE(channel, DMA_CH_SR, dma_ch_isr);
 		XGMAC_DMA_IOWRITE(channel, DMA_CH_SR, dma_ch_isr);
@@ -1537,7 +1537,7 @@ static void xgbe_tx_timeout(struct net_device *netdev)
 	struct xgbe_prv_data *pdata = netdev_priv(netdev);
 	struct xgbe_prv_data *pdata = netdev_priv(netdev);
 
 
 	netdev_warn(netdev, "tx timeout, device restarting\n");
 	netdev_warn(netdev, "tx timeout, device restarting\n");
-	queue_work(pdata->dev_workqueue, &pdata->restart_work);
+	schedule_work(&pdata->restart_work);
 }
 }
 
 
 static struct rtnl_link_stats64 *xgbe_get_stats64(struct net_device *netdev,
 static struct rtnl_link_stats64 *xgbe_get_stats64(struct net_device *netdev,