Эх сурвалжийг харах

staging: et131x: Add some items to the TODO list

Adding some trivial formatting suggestions made by Dan Carpenter to
the TODO.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Einon 12 жил өмнө
parent
commit
966630bc79

+ 6 - 1
drivers/staging/et131x/README

@@ -11,7 +11,12 @@ TODO:
 	- Look at reducing the number of spinlocks
 	- Look at reducing the number of spinlocks
 	- Simplify code in nic_rx_pkts(), when determining multicast_pkts_rcvd
 	- Simplify code in nic_rx_pkts(), when determining multicast_pkts_rcvd
 	- Implement NAPI support
 	- Implement NAPI support
-	- in et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with	  kfree_skb().
+	- In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with kfree_skb().
+	- Reduce the number of split lines by careful consideration of variable names etc.
+	- Do this in et131x.c:
+                struct fbr_lookup *fbr;
+                fbr = rx_local->fbr[id];
+	  Then replace all the instances of "rx_local->fbr[id]" with fbr.
 
 
 Please send patches to:
 Please send patches to:
 	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 	Greg Kroah-Hartman <gregkh@linuxfoundation.org>