Browse Source

pinctrl: st: st_pctl_dt_parse_groups simplify expression

for_each_property_of_node(pins, pp) checks that pp is not NULL.
So there is no need to check it inside the loop.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Heinrich Schuchardt 8 years ago
parent
commit
95bdb0ea36
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/pinctrl/pinctrl-st.c

+ 1 - 1
drivers/pinctrl/pinctrl-st.c

@@ -1181,7 +1181,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
 		if (!strcmp(pp->name, "name"))
 		if (!strcmp(pp->name, "name"))
 			continue;
 			continue;
 
 
-		if (pp  && (pp->length/sizeof(__be32)) >= OF_GPIO_ARGS_MIN) {
+		if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) {
 			npins++;
 			npins++;
 		} else {
 		} else {
 			pr_warn("Invalid st,pins in %s node\n", np->name);
 			pr_warn("Invalid st,pins in %s node\n", np->name);