浏览代码

staging: fsl-mc: fix device ref counting

Drop unneeded get_device() call at device creation
and, as per documentation, drop reference count
after using device_find_child() return.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laurentiu Tudor 8 年之前
父节点
当前提交
95b5daf532
共有 2 个文件被更改,包括 1 次插入1 次删除
  1. 1 0
      drivers/staging/fsl-mc/bus/dprc-driver.c
  2. 0 1
      drivers/staging/fsl-mc/bus/fsl-mc-bus.c

+ 1 - 0
drivers/staging/fsl-mc/bus/dprc-driver.c

@@ -188,6 +188,7 @@ static void dprc_add_new_devices(struct fsl_mc_device *mc_bus_dev,
 		child_dev = fsl_mc_device_lookup(obj_desc, mc_bus_dev);
 		if (child_dev) {
 			check_plugged_state_change(child_dev, obj_desc);
+			put_device(&child_dev->dev);
 			continue;
 		}
 

+ 0 - 1
drivers/staging/fsl-mc/bus/fsl-mc-bus.c

@@ -537,7 +537,6 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc,
 		goto error_cleanup_dev;
 	}
 
-	(void)get_device(&mc_dev->dev);
 	dev_dbg(parent_dev, "added %s\n", dev_name(&mc_dev->dev));
 
 	*new_mc_dev = mc_dev;