Browse Source

batman-adv: Reject unicast packet with zero/mcast dst address

An unicast batman-adv packet cannot be transmitted to a multicast or zero
mac address. So reject incoming packets which still have these classes of
addresses as destination mac address in the outer ethernet header.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Sven Eckelmann 9 years ago
parent
commit
93bbaab455
1 changed files with 4 additions and 4 deletions
  1. 4 4
      net/batman-adv/routing.c

+ 4 - 4
net/batman-adv/routing.c

@@ -364,8 +364,8 @@ int batadv_recv_icmp_packet(struct sk_buff *skb,
 
 
 	ethhdr = eth_hdr(skb);
 	ethhdr = eth_hdr(skb);
 
 
-	/* packet with unicast indication but broadcast recipient */
-	if (is_broadcast_ether_addr(ethhdr->h_dest))
+	/* packet with unicast indication but non-unicast recipient */
+	if (!is_valid_ether_addr(ethhdr->h_dest))
 		goto free_skb;
 		goto free_skb;
 
 
 	/* packet with broadcast/multicast sender address */
 	/* packet with broadcast/multicast sender address */
@@ -462,8 +462,8 @@ static int batadv_check_unicast_packet(struct batadv_priv *bat_priv,
 
 
 	ethhdr = eth_hdr(skb);
 	ethhdr = eth_hdr(skb);
 
 
-	/* packet with unicast indication but broadcast recipient */
-	if (is_broadcast_ether_addr(ethhdr->h_dest))
+	/* packet with unicast indication but non-unicast recipient */
+	if (!is_valid_ether_addr(ethhdr->h_dest))
 		return -EBADR;
 		return -EBADR;
 
 
 	/* packet with broadcast/multicast sender address */
 	/* packet with broadcast/multicast sender address */