Browse Source

rocker: fix error return code in rocker_world_check_init()

Fix to return error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: e420114eef4a ("rocker: introduce worlds infrastructure")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Wei Yongjun 8 years ago
parent
commit
92d230dd8c
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/ethernet/rocker/rocker_main.c

+ 1 - 1
drivers/net/ethernet/rocker/rocker_main.c

@@ -1471,7 +1471,7 @@ static int rocker_world_check_init(struct rocker_port *rocker_port)
 	if (rocker->wops) {
 	if (rocker->wops) {
 		if (rocker->wops->mode != mode) {
 		if (rocker->wops->mode != mode) {
 			dev_err(&rocker->pdev->dev, "hardware has ports in different worlds, which is not supported\n");
 			dev_err(&rocker->pdev->dev, "hardware has ports in different worlds, which is not supported\n");
-			return err;
+			return -EINVAL;
 		}
 		}
 		return 0;
 		return 0;
 	}
 	}