Browse Source

f2fs crypto: delete an unnecessary check before the function call "key_put"

The key_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Markus Elfring 10 years ago
parent
commit
92859a5efd
1 changed files with 1 additions and 2 deletions
  1. 1 2
      fs/f2fs/crypto_key.c

+ 1 - 2
fs/f2fs/crypto_key.c

@@ -92,8 +92,7 @@ static void f2fs_free_crypt_info(struct f2fs_crypt_info *ci)
 	if (!ci)
 	if (!ci)
 		return;
 		return;
 
 
-	if (ci->ci_keyring_key)
-		key_put(ci->ci_keyring_key);
+	key_put(ci->ci_keyring_key);
 	crypto_free_ablkcipher(ci->ci_ctfm);
 	crypto_free_ablkcipher(ci->ci_ctfm);
 	kmem_cache_free(f2fs_crypt_info_cachep, ci);
 	kmem_cache_free(f2fs_crypt_info_cachep, ci);
 }
 }