Browse Source

drm/nouveau: Make clock gate support conditional

The recently introduced clock gate support breaks on Tegra chips because
no thermal support is enabled for those devices. Conditionalize the code
on the existence of thermal support to fix this.

Fixes: b138eca661cc ("drm/nouveau: Add support for basic clockgating on Kepler1")
Cc: Martin Peres <martin.peres@free.fr>
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Thierry Reding 7 years ago
parent
commit
9225626989
1 changed files with 3 additions and 3 deletions
  1. 3 3
      drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c

+ 3 - 3
drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c

@@ -301,7 +301,7 @@ nvkm_therm_attr_set(struct nvkm_therm *therm,
 void
 void
 nvkm_therm_clkgate_enable(struct nvkm_therm *therm)
 nvkm_therm_clkgate_enable(struct nvkm_therm *therm)
 {
 {
-	if (!therm->func->clkgate_enable || !therm->clkgating_enabled)
+	if (!therm || !therm->func->clkgate_enable || !therm->clkgating_enabled)
 		return;
 		return;
 
 
 	nvkm_debug(&therm->subdev,
 	nvkm_debug(&therm->subdev,
@@ -312,7 +312,7 @@ nvkm_therm_clkgate_enable(struct nvkm_therm *therm)
 void
 void
 nvkm_therm_clkgate_fini(struct nvkm_therm *therm, bool suspend)
 nvkm_therm_clkgate_fini(struct nvkm_therm *therm, bool suspend)
 {
 {
-	if (!therm->func->clkgate_fini || !therm->clkgating_enabled)
+	if (!therm || !therm->func->clkgate_fini || !therm->clkgating_enabled)
 		return;
 		return;
 
 
 	nvkm_debug(&therm->subdev,
 	nvkm_debug(&therm->subdev,
@@ -395,7 +395,7 @@ void
 nvkm_therm_clkgate_init(struct nvkm_therm *therm,
 nvkm_therm_clkgate_init(struct nvkm_therm *therm,
 			const struct nvkm_therm_clkgate_pack *p)
 			const struct nvkm_therm_clkgate_pack *p)
 {
 {
-	if (!therm->func->clkgate_init || !therm->clkgating_enabled)
+	if (!therm || !therm->func->clkgate_init || !therm->clkgating_enabled)
 		return;
 		return;
 
 
 	therm->func->clkgate_init(therm, p);
 	therm->func->clkgate_init(therm, p);