Browse Source

hwmon: (nct7802) Fix integer overflow seen when writing voltage limits

Writing a large value into a voltage limit attribute can result
in an overflow due to an auto-conversion from unsigned long to
unsigned int.

Cc: Constantine Shulyupin <const@MakeLinux.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org # v4.1+
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Guenter Roeck 10 years ago
parent
commit
9200bc4c28
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/hwmon/nct7802.c

+ 1 - 1
drivers/hwmon/nct7802.c

@@ -195,7 +195,7 @@ abort:
 }
 }
 
 
 static int nct7802_write_voltage(struct nct7802_data *data, int nr, int index,
 static int nct7802_write_voltage(struct nct7802_data *data, int nr, int index,
-				 unsigned int voltage)
+				 unsigned long voltage)
 {
 {
 	int shift = 8 - REG_VOLTAGE_LIMIT_MSB_SHIFT[index - 1][nr];
 	int shift = 8 - REG_VOLTAGE_LIMIT_MSB_SHIFT[index - 1][nr];
 	int err;
 	int err;