Browse Source

net: USB: Deletion of unnecessary checks before the function call "kfree"

The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Markus Elfring 10 năm trước cách đây
mục cha
commit
91ecee6846

+ 1 - 2
drivers/net/usb/asix_devices.c

@@ -487,8 +487,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
 
 
 static void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
 static void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
 {
 {
-	if (dev->driver_priv)
-		kfree(dev->driver_priv);
+	kfree(dev->driver_priv);
 }
 }
 
 
 static const struct ethtool_ops ax88178_ethtool_ops = {
 static const struct ethtool_ops ax88178_ethtool_ops = {

+ 1 - 2
drivers/net/usb/hso.c

@@ -2746,8 +2746,7 @@ exit:
 		tty_unregister_device(tty_drv, serial->minor);
 		tty_unregister_device(tty_drv, serial->minor);
 		kfree(serial);
 		kfree(serial);
 	}
 	}
-	if (hso_dev)
-		kfree(hso_dev);
+	kfree(hso_dev);
 	return NULL;
 	return NULL;
 
 
 }
 }