浏览代码

USB: garmin_gps: remove bogus disconnect test in close

Remove bogus disconnect test for serial device being NULL in close. This
can never happen as close is guaranteed to be called before the last tty
reference is dropped (and port->serial is cleared).

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold 12 年之前
父节点
当前提交
9197272452
共有 1 个文件被更改,包括 0 次插入4 次删除
  1. 0 4
      drivers/usb/serial/garmin_gps.c

+ 0 - 4
drivers/usb/serial/garmin_gps.c

@@ -946,16 +946,12 @@ static int garmin_open(struct tty_struct *tty, struct usb_serial_port *port)
 
 
 static void garmin_close(struct usb_serial_port *port)
 static void garmin_close(struct usb_serial_port *port)
 {
 {
-	struct usb_serial *serial = port->serial;
 	struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
 	struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
 
 
 	dev_dbg(&port->dev, "%s - port %d - mode=%d state=%d flags=0x%X\n",
 	dev_dbg(&port->dev, "%s - port %d - mode=%d state=%d flags=0x%X\n",
 		__func__, port->number, garmin_data_p->mode,
 		__func__, port->number, garmin_data_p->mode,
 		garmin_data_p->state, garmin_data_p->flags);
 		garmin_data_p->state, garmin_data_p->flags);
 
 
-	if (!serial)
-		return;
-
 	garmin_clear(garmin_data_p);
 	garmin_clear(garmin_data_p);
 
 
 	/* shutdown our urbs */
 	/* shutdown our urbs */