Browse Source

USB: ehci-dbg.c: move assignment out of if () block

We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Greg Kroah-Hartman 10 years ago
parent
commit
911fdb6eca
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/usb/host/ehci-dbg.c

+ 2 - 1
drivers/usb/host/ehci-dbg.c

@@ -628,7 +628,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf)
 	unsigned		i;
 	unsigned		i;
 	__hc32			tag;
 	__hc32			tag;
 
 
-	if (!(seen = kmalloc (DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC)))
+	seen = kmalloc(DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC);
+	if (!seen)
 		return 0;
 		return 0;
 	seen_count = 0;
 	seen_count = 0;