瀏覽代碼

root dentries need RCU-delayed freeing

Since mountpoint crossing can happen without leaving lazy mode,
root dentries do need the same protection against having their
memory freed without RCU delay as everything else in the tree.

It's partially hidden by RCU delay between detaching from the
mount tree and dropping the vfsmount reference, but the starting
point of pathwalk can be on an already detached mount, in which
case umount-caused RCU delay has already passed by the time the
lazy pathwalk grabs rcu_read_lock().  If the starting point
happens to be at the root of that vfsmount *and* that vfsmount
covers the entire filesystem, we get trouble.

Fixes: 48a066e72d97 ("RCU'd vsfmounts")
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Al Viro 7 年之前
父節點
當前提交
90bad5e05b
共有 1 個文件被更改,包括 4 次插入2 次删除
  1. 4 2
      fs/dcache.c

+ 4 - 2
fs/dcache.c

@@ -1932,10 +1932,12 @@ struct dentry *d_make_root(struct inode *root_inode)
 
 
 	if (root_inode) {
 	if (root_inode) {
 		res = d_alloc_anon(root_inode->i_sb);
 		res = d_alloc_anon(root_inode->i_sb);
-		if (res)
+		if (res) {
+			res->d_flags |= DCACHE_RCUACCESS;
 			d_instantiate(res, root_inode);
 			d_instantiate(res, root_inode);
-		else
+		} else {
 			iput(root_inode);
 			iput(root_inode);
+		}
 	}
 	}
 	return res;
 	return res;
 }
 }