Browse Source

usb: ehci: ohci: fix bool assignments

When assigning bool use true instead of 1. If declaring it as static and
it's false there's no need to initialize it, since static variables are
zeroed by default.

Caught by coccinelle.

Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geyslan G. Bem 9 years ago
parent
commit
900937c037
3 changed files with 4 additions and 4 deletions
  1. 1 1
      drivers/usb/host/ehci-hcd.c
  2. 2 2
      drivers/usb/host/ohci-hcd.c
  3. 1 1
      drivers/usb/host/u132-hcd.c

+ 1 - 1
drivers/usb/host/ehci-hcd.c

@@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO);
 MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets");
 MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets");
 
 
 /* for flakey hardware, ignore overcurrent indicators */
 /* for flakey hardware, ignore overcurrent indicators */
-static bool ignore_oc = 0;
+static bool ignore_oc;
 module_param (ignore_oc, bool, S_IRUGO);
 module_param (ignore_oc, bool, S_IRUGO);
 MODULE_PARM_DESC (ignore_oc, "ignore bogus hardware overcurrent indications");
 MODULE_PARM_DESC (ignore_oc, "ignore bogus hardware overcurrent indications");
 
 

+ 2 - 2
drivers/usb/host/ohci-hcd.c

@@ -99,13 +99,13 @@ static void io_watchdog_func(unsigned long _ohci);
 
 
 
 
 /* Some boards misreport power switching/overcurrent */
 /* Some boards misreport power switching/overcurrent */
-static bool distrust_firmware = 1;
+static bool distrust_firmware = true;
 module_param (distrust_firmware, bool, 0);
 module_param (distrust_firmware, bool, 0);
 MODULE_PARM_DESC (distrust_firmware,
 MODULE_PARM_DESC (distrust_firmware,
 	"true to distrust firmware power/overcurrent setup");
 	"true to distrust firmware power/overcurrent setup");
 
 
 /* Some boards leave IR set wrongly, since they fail BIOS/SMM handshakes */
 /* Some boards leave IR set wrongly, since they fail BIOS/SMM handshakes */
-static bool no_handshake = 0;
+static bool no_handshake;
 module_param (no_handshake, bool, 0);
 module_param (no_handshake, bool, 0);
 MODULE_PARM_DESC (no_handshake, "true (not default) disables BIOS handshake");
 MODULE_PARM_DESC (no_handshake, "true (not default) disables BIOS handshake");
 
 

+ 1 - 1
drivers/usb/host/u132-hcd.c

@@ -73,7 +73,7 @@ MODULE_LICENSE("GPL");
 #define INT_MODULE_PARM(n, v) static int n = v;module_param(n, int, 0444)
 #define INT_MODULE_PARM(n, v) static int n = v;module_param(n, int, 0444)
 INT_MODULE_PARM(testing, 0);
 INT_MODULE_PARM(testing, 0);
 /* Some boards misreport power switching/overcurrent*/
 /* Some boards misreport power switching/overcurrent*/
-static bool distrust_firmware = 1;
+static bool distrust_firmware = true;
 module_param(distrust_firmware, bool, 0);
 module_param(distrust_firmware, bool, 0);
 MODULE_PARM_DESC(distrust_firmware, "true to distrust firmware power/overcurren"
 MODULE_PARM_DESC(distrust_firmware, "true to distrust firmware power/overcurren"
 	"t setup");
 	"t setup");