Browse Source

thermal: underflow bug in imx_set_trip_temp()

We recently changed this from unsigned long to int so it introduced an
underflow bug.

Fixes: 17e8351a7739 ('thermal: consistently use int for temperatures')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Dan Carpenter 10 years ago
parent
commit
8fb2b9ac2a
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/thermal/imx_thermal.c

+ 1 - 1
drivers/thermal/imx_thermal.c

@@ -288,7 +288,7 @@ static int imx_set_trip_temp(struct thermal_zone_device *tz, int trip,
 	if (trip == IMX_TRIP_CRITICAL)
 		return -EPERM;
 
-	if (temp > IMX_TEMP_PASSIVE)
+	if (temp < 0 || temp > IMX_TEMP_PASSIVE)
 		return -EINVAL;
 
 	data->temp_passive = temp;