浏览代码

xfrm: optimise to search the inexact policy list

The policies are organized into list by priority ascent of policy,
so it is unnecessary to continue to loop the policy if the priority
of current looped police is larger than or equal priority which is
from the policy_bydst list.

This allows to match policy with ~0U priority in inexact list too.

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Li RongQing 10 年之前
父节点
当前提交
8faf491e64
共有 1 个文件被更改,包括 8 次插入3 次删除
  1. 8 3
      net/xfrm/xfrm_policy.c

+ 8 - 3
net/xfrm/xfrm_policy.c

@@ -1114,6 +1114,9 @@ static struct xfrm_policy *xfrm_policy_lookup_bytype(struct net *net, u8 type,
 	}
 	}
 	chain = &net->xfrm.policy_inexact[dir];
 	chain = &net->xfrm.policy_inexact[dir];
 	hlist_for_each_entry(pol, chain, bydst) {
 	hlist_for_each_entry(pol, chain, bydst) {
+		if ((pol->priority >= priority) && ret)
+			break;
+
 		err = xfrm_policy_match(pol, fl, type, family, dir);
 		err = xfrm_policy_match(pol, fl, type, family, dir);
 		if (err) {
 		if (err) {
 			if (err == -ESRCH)
 			if (err == -ESRCH)
@@ -1122,7 +1125,7 @@ static struct xfrm_policy *xfrm_policy_lookup_bytype(struct net *net, u8 type,
 				ret = ERR_PTR(err);
 				ret = ERR_PTR(err);
 				goto fail;
 				goto fail;
 			}
 			}
-		} else if (pol->priority < priority) {
+		} else {
 			ret = pol;
 			ret = pol;
 			break;
 			break;
 		}
 		}
@@ -3203,9 +3206,11 @@ static struct xfrm_policy *xfrm_migrate_policy_find(const struct xfrm_selector *
 	}
 	}
 	chain = &net->xfrm.policy_inexact[dir];
 	chain = &net->xfrm.policy_inexact[dir];
 	hlist_for_each_entry(pol, chain, bydst) {
 	hlist_for_each_entry(pol, chain, bydst) {
+		if ((pol->priority >= priority) && ret)
+			break;
+
 		if (xfrm_migrate_selector_match(sel, &pol->selector) &&
 		if (xfrm_migrate_selector_match(sel, &pol->selector) &&
-		    pol->type == type &&
-		    pol->priority < priority) {
+		    pol->type == type) {
 			ret = pol;
 			ret = pol;
 			break;
 			break;
 		}
 		}