瀏覽代碼

sched: Add better debug output for might_sleep()

might_sleep() can tell us where interrupts have been disabled, but we
have no idea what disabled preemption. Add some debug infrastructure.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1391803122-4425-4-git-send-email-bigeasy@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Thomas Gleixner 11 年之前
父節點
當前提交
8f47b1871b
共有 2 個文件被更改,包括 24 次插入2 次删除
  1. 3 0
      include/linux/sched.h
  2. 21 2
      kernel/sched/core.c

+ 3 - 0
include/linux/sched.h

@@ -1463,6 +1463,9 @@ struct task_struct {
 	struct mutex perf_event_mutex;
 	struct mutex perf_event_mutex;
 	struct list_head perf_event_list;
 	struct list_head perf_event_list;
 #endif
 #endif
+#ifdef CONFIG_DEBUG_PREEMPT
+	unsigned long preempt_disable_ip;
+#endif
 #ifdef CONFIG_NUMA
 #ifdef CONFIG_NUMA
 	struct mempolicy *mempolicy;	/* Protected by alloc_lock */
 	struct mempolicy *mempolicy;	/* Protected by alloc_lock */
 	short il_next;
 	short il_next;

+ 21 - 2
kernel/sched/core.c

@@ -2501,8 +2501,13 @@ void __kprobes preempt_count_add(int val)
 	DEBUG_LOCKS_WARN_ON((preempt_count() & PREEMPT_MASK) >=
 	DEBUG_LOCKS_WARN_ON((preempt_count() & PREEMPT_MASK) >=
 				PREEMPT_MASK - 10);
 				PREEMPT_MASK - 10);
 #endif
 #endif
-	if (preempt_count() == val)
-		trace_preempt_off(CALLER_ADDR0, get_parent_ip(CALLER_ADDR1));
+	if (preempt_count() == val) {
+		unsigned long ip = get_parent_ip(CALLER_ADDR1);
+#ifdef CONFIG_DEBUG_PREEMPT
+		current->preempt_disable_ip = ip;
+#endif
+		trace_preempt_off(CALLER_ADDR0, ip);
+	}
 }
 }
 EXPORT_SYMBOL(preempt_count_add);
 EXPORT_SYMBOL(preempt_count_add);
 
 
@@ -2545,6 +2550,13 @@ static noinline void __schedule_bug(struct task_struct *prev)
 	print_modules();
 	print_modules();
 	if (irqs_disabled())
 	if (irqs_disabled())
 		print_irqtrace_events(prev);
 		print_irqtrace_events(prev);
+#ifdef CONFIG_DEBUG_PREEMPT
+	if (in_atomic_preempt_off()) {
+		pr_err("Preemption disabled at:");
+		print_ip_sym(current->preempt_disable_ip);
+		pr_cont("\n");
+	}
+#endif
 	dump_stack();
 	dump_stack();
 	add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
 	add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
 }
 }
@@ -6946,6 +6958,13 @@ void __might_sleep(const char *file, int line, int preempt_offset)
 	debug_show_held_locks(current);
 	debug_show_held_locks(current);
 	if (irqs_disabled())
 	if (irqs_disabled())
 		print_irqtrace_events(current);
 		print_irqtrace_events(current);
+#ifdef CONFIG_DEBUG_PREEMPT
+	if (!preempt_count_equals(preempt_offset)) {
+		pr_err("Preemption disabled at:");
+		print_ip_sym(current->preempt_disable_ip);
+		pr_cont("\n");
+	}
+#endif
 	dump_stack();
 	dump_stack();
 }
 }
 EXPORT_SYMBOL(__might_sleep);
 EXPORT_SYMBOL(__might_sleep);