浏览代码

inetpeer: speed up inetpeer_invalidate_tree()

As measured in my prior patch ("sch_netem: faster rb tree removal"),
rbtree_postorder_for_each_entry_safe() is nice looking but much slower
than using rb_next() directly, except when tree is small enough
to fit in CPU caches (then the cost is the same)

From: Eric Dumazet <edumazet@google.com>

Signed-off-by: David S. Miller <davem@davemloft.net>
Eric Dumazet 8 年之前
父节点
当前提交
8f1975e31d
共有 1 个文件被更改,包括 7 次插入4 次删除
  1. 7 4
      net/ipv4/inetpeer.c

+ 7 - 4
net/ipv4/inetpeer.c

@@ -284,14 +284,17 @@ EXPORT_SYMBOL(inet_peer_xrlim_allow);
 
 
 void inetpeer_invalidate_tree(struct inet_peer_base *base)
 void inetpeer_invalidate_tree(struct inet_peer_base *base)
 {
 {
-	struct inet_peer *p, *n;
+	struct rb_node *p = rb_first(&base->rb_root);
 
 
-	rbtree_postorder_for_each_entry_safe(p, n, &base->rb_root, rb_node) {
-		inet_putpeer(p);
+	while (p) {
+		struct inet_peer *peer = rb_entry(p, struct inet_peer, rb_node);
+
+		p = rb_next(p);
+		rb_erase(&peer->rb_node, &base->rb_root);
+		inet_putpeer(peer);
 		cond_resched();
 		cond_resched();
 	}
 	}
 
 
-	base->rb_root = RB_ROOT;
 	base->total = 0;
 	base->total = 0;
 }
 }
 EXPORT_SYMBOL(inetpeer_invalidate_tree);
 EXPORT_SYMBOL(inetpeer_invalidate_tree);