瀏覽代碼

nvme-fabrics: Fix memory leaks in nvmf_parse_options()

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Bart Van Assche 8 年之前
父節點
當前提交
8eadfcb1b6
共有 1 個文件被更改,包括 2 次插入0 次删除
  1. 2 0
      drivers/nvme/host/fabrics.c

+ 2 - 0
drivers/nvme/host/fabrics.c

@@ -666,10 +666,12 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
 			if (nqnlen >= NVMF_NQN_SIZE) {
 			if (nqnlen >= NVMF_NQN_SIZE) {
 				pr_err("%s needs to be < %d bytes\n",
 				pr_err("%s needs to be < %d bytes\n",
 					p, NVMF_NQN_SIZE);
 					p, NVMF_NQN_SIZE);
+				kfree(p);
 				ret = -EINVAL;
 				ret = -EINVAL;
 				goto out;
 				goto out;
 			}
 			}
 			opts->host = nvmf_host_add(p);
 			opts->host = nvmf_host_add(p);
+			kfree(p);
 			if (!opts->host) {
 			if (!opts->host) {
 				ret = -ENOMEM;
 				ret = -ENOMEM;
 				goto out;
 				goto out;