Browse Source

usb: gadget: mass_storage: set msg_registered after msg registered

If there is no UDC available, the msg register will fail and this
flag will not be set, but the driver is already added into pending
driver list, then the module removal modprobe -r can not remove
the driver from the pending list.

Signed-off-by: Li Jun <jun.li@nxp.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Li Jun 8 years ago
parent
commit
8e55d30322
1 changed files with 6 additions and 2 deletions
  1. 6 2
      drivers/usb/gadget/legacy/mass_storage.c

+ 6 - 2
drivers/usb/gadget/legacy/mass_storage.c

@@ -210,7 +210,6 @@ static int msg_bind(struct usb_composite_dev *cdev)
 	usb_composite_overwrite_options(cdev, &coverwrite);
 	usb_composite_overwrite_options(cdev, &coverwrite);
 	dev_info(&cdev->gadget->dev,
 	dev_info(&cdev->gadget->dev,
 		 DRIVER_DESC ", version: " DRIVER_VERSION "\n");
 		 DRIVER_DESC ", version: " DRIVER_VERSION "\n");
-	set_bit(0, &msg_registered);
 	return 0;
 	return 0;
 
 
 fail_otg_desc:
 fail_otg_desc:
@@ -257,7 +256,12 @@ MODULE_LICENSE("GPL");
 
 
 static int __init msg_init(void)
 static int __init msg_init(void)
 {
 {
-	return usb_composite_probe(&msg_driver);
+	int ret;
+
+	ret = usb_composite_probe(&msg_driver);
+	set_bit(0, &msg_registered);
+
+	return ret;
 }
 }
 module_init(msg_init);
 module_init(msg_init);