Browse Source

dmaengine: qcom_hidma: hide MSI handler when unused

The newly added MSI support causes a harmless warning when MSI
is disabled:

drivers/dma/qcom/hidma.c:558:20: error: 'hidma_chirq_handler_msi' defined but not used [-Werror=unused-function]

This adds another #ifdef to match that around the users of the function.

Fixes: 1c0e3e82a7fb ("dmaengine: qcom_hidma: add MSI support for interrupts")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sinan Kaya <okaya@codeaurora.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Arnd Bergmann 8 years ago
parent
commit
8cc12b26b4
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/dma/qcom/hidma.c

+ 2 - 0
drivers/dma/qcom/hidma.c

@@ -555,6 +555,7 @@ static irqreturn_t hidma_chirq_handler(int chirq, void *arg)
 	return hidma_ll_inthandler(chirq, lldev);
 	return hidma_ll_inthandler(chirq, lldev);
 }
 }
 
 
+#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg)
 static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg)
 {
 {
 	struct hidma_lldev **lldevp = arg;
 	struct hidma_lldev **lldevp = arg;
@@ -563,6 +564,7 @@ static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg)
 	return hidma_ll_inthandler_msi(chirq, *lldevp,
 	return hidma_ll_inthandler_msi(chirq, *lldevp,
 				       1 << (chirq - dmadev->msi_virqbase));
 				       1 << (chirq - dmadev->msi_virqbase));
 }
 }
+#endif
 
 
 static ssize_t hidma_show_values(struct device *dev,
 static ssize_t hidma_show_values(struct device *dev,
 				 struct device_attribute *attr, char *buf)
 				 struct device_attribute *attr, char *buf)