瀏覽代碼

fs: dcache: Use READ_ONCE when accessing i_dir_seq

i_dir_seq is subject to concurrent modification by a cmpxchg or
store-release operation, so ensure that the relaxed access in
d_alloc_parallel uses READ_ONCE.

Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Will Deacon 7 年之前
父節點
當前提交
8cc07c808c
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      fs/dcache.c

+ 1 - 1
fs/dcache.c

@@ -2507,7 +2507,7 @@ retry:
 	}
 
 	hlist_bl_lock(b);
-	if (unlikely(parent->d_inode->i_dir_seq != seq)) {
+	if (unlikely(READ_ONCE(parent->d_inode->i_dir_seq) != seq)) {
 		hlist_bl_unlock(b);
 		rcu_read_unlock();
 		goto retry;