Эх сурвалжийг харах

ARM: S3C24XX: Use PWM lookup table for mach-h1940

Use a PWM lookup table to provide the PWM to the pwm-backlight device.
The driver has a legacy code path that is required only because boards
still use the legacy method of requesting PWMs by global ID. Replacing
these usages allows that legacy fallback to be removed.

Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Kukjin Kim <kgene@kernel.org>
Thierry Reding 9 жил өмнө
parent
commit
8c78aaa6ee

+ 7 - 3
arch/arm/mach-s3c24xx/mach-h1940.c

@@ -25,6 +25,7 @@
 #include <linux/gpio.h>
 #include <linux/gpio.h>
 #include <linux/input.h>
 #include <linux/input.h>
 #include <linux/gpio_keys.h>
 #include <linux/gpio_keys.h>
+#include <linux/pwm.h>
 #include <linux/pwm_backlight.h>
 #include <linux/pwm_backlight.h>
 #include <linux/i2c.h>
 #include <linux/i2c.h>
 #include <linux/leds.h>
 #include <linux/leds.h>
@@ -469,6 +470,11 @@ static struct s3c24xx_mci_pdata h1940_mmc_cfg __initdata = {
 	.ocr_avail     = MMC_VDD_32_33,
 	.ocr_avail     = MMC_VDD_32_33,
 };
 };
 
 
+static struct pwm_lookup h1940_pwm_lookup[] = {
+	PWM_LOOKUP("samsung-pwm", 0, "pwm-backlight", NULL, 36296,
+		   PWM_POLARITY_NORMAL),
+};
+
 static int h1940_backlight_init(struct device *dev)
 static int h1940_backlight_init(struct device *dev)
 {
 {
 	gpio_request(S3C2410_GPB(0), "Backlight");
 	gpio_request(S3C2410_GPB(0), "Backlight");
@@ -503,11 +509,8 @@ static void h1940_backlight_exit(struct device *dev)
 
 
 
 
 static struct platform_pwm_backlight_data backlight_data = {
 static struct platform_pwm_backlight_data backlight_data = {
-	.pwm_id         = 0,
 	.max_brightness = 100,
 	.max_brightness = 100,
 	.dft_brightness = 50,
 	.dft_brightness = 50,
-	/* tcnt = 0x31 */
-	.pwm_period_ns  = 36296,
 	.enable_gpio    = -1,
 	.enable_gpio    = -1,
 	.init           = h1940_backlight_init,
 	.init           = h1940_backlight_init,
 	.notify		= h1940_backlight_notify,
 	.notify		= h1940_backlight_notify,
@@ -725,6 +728,7 @@ static void __init h1940_init(void)
 	gpio_request(H1940_LATCH_SD_POWER, "SD power");
 	gpio_request(H1940_LATCH_SD_POWER, "SD power");
 	gpio_direction_output(H1940_LATCH_SD_POWER, 0);
 	gpio_direction_output(H1940_LATCH_SD_POWER, 0);
 
 
+	pwm_add_table(h1940_pwm_lookup, ARRAY_SIZE(h1940_pwm_lookup));
 	platform_add_devices(h1940_devices, ARRAY_SIZE(h1940_devices));
 	platform_add_devices(h1940_devices, ARRAY_SIZE(h1940_devices));
 
 
 	gpio_request(S3C2410_GPA(1), "Red LED blink");
 	gpio_request(S3C2410_GPA(1), "Red LED blink");