Przeglądaj źródła

netfilter: nf_tables: fix potential NULL-ptr deref in nf_tables_dump_obj_done()

If there is no NFTA_OBJ_TABLE and NFTA_OBJ_TYPE, the c.data will be NULL in
nf_tables_getobj(). So before free filter->table in nf_tables_dump_obj_done(),
we need to check if filter is NULL first.

Fixes: e46abbcc05aa ("netfilter: nf_tables: Allow table names of up to 255 chars")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Hangbin Liu 7 lat temu
rodzic
commit
8bea728dce
1 zmienionych plików z 4 dodań i 2 usunięć
  1. 4 2
      net/netfilter/nf_tables_api.c

+ 4 - 2
net/netfilter/nf_tables_api.c

@@ -4665,8 +4665,10 @@ static int nf_tables_dump_obj_done(struct netlink_callback *cb)
 {
 {
 	struct nft_obj_filter *filter = cb->data;
 	struct nft_obj_filter *filter = cb->data;
 
 
-	kfree(filter->table);
-	kfree(filter);
+	if (filter) {
+		kfree(filter->table);
+		kfree(filter);
+	}
 
 
 	return 0;
 	return 0;
 }
 }