Ver código fonte

EDAC, altera: Fix error handling path in altr_edac_device_probe()

Return the proper error value if devm_ioremap() fails (and not 0).

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Thor Thayer <thor.thayer@linux.intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170816050506.14541-1-christophe.jaillet@wanadoo.fr
[ Massage commit message. ]
Signed-off-by: Borislav Petkov <bp@suse.de>
Christophe JAILLET 8 anos atrás
pai
commit
8b073d945c
1 arquivos alterados com 3 adições e 1 exclusões
  1. 3 1
      drivers/edac/altera_edac.c

+ 3 - 1
drivers/edac/altera_edac.c

@@ -747,8 +747,10 @@ static int altr_edac_device_probe(struct platform_device *pdev)
 	drvdata->edac_dev_name = ecc_name;
 	drvdata->edac_dev_name = ecc_name;
 
 
 	drvdata->base = devm_ioremap(&pdev->dev, r->start, resource_size(r));
 	drvdata->base = devm_ioremap(&pdev->dev, r->start, resource_size(r));
-	if (!drvdata->base)
+	if (!drvdata->base) {
+		res = -ENOMEM;
 		goto fail1;
 		goto fail1;
+	}
 
 
 	/* Get driver specific data for this EDAC device */
 	/* Get driver specific data for this EDAC device */
 	drvdata->data = of_match_node(altr_edac_device_of_match, np)->data;
 	drvdata->data = of_match_node(altr_edac_device_of_match, np)->data;