Эх сурвалжийг харах

regulator: da9063: Do not hardcode return values

Propagate the error values returned by the function instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
Sachin Kamat 11 жил өмнө
parent
commit
8a7963d55b

+ 2 - 2
drivers/regulator/da9063-regulator.c

@@ -363,7 +363,7 @@ static int da9063_set_suspend_voltage(struct regulator_dev *rdev, int uV)
 
 
 	sel = regulator_map_voltage_linear(rdev, uV, uV);
 	sel = regulator_map_voltage_linear(rdev, uV, uV);
 	if (sel < 0)
 	if (sel < 0)
-		return -EINVAL;
+		return sel;
 
 
 	sel <<= ffs(rdev->desc->vsel_mask) - 1;
 	sel <<= ffs(rdev->desc->vsel_mask) - 1;
 
 
@@ -755,7 +755,7 @@ static int da9063_regulator_probe(struct platform_device *pdev)
 	if (ret < 0) {
 	if (ret < 0) {
 		dev_err(&pdev->dev,
 		dev_err(&pdev->dev,
 			"Error while reading BUCKs configuration\n");
 			"Error while reading BUCKs configuration\n");
-		return -EIO;
+		return ret;
 	}
 	}
 	bcores_merged = val & DA9063_BCORE_MERGE;
 	bcores_merged = val & DA9063_BCORE_MERGE;
 	bmem_bio_merged = val & DA9063_BUCK_MERGE;
 	bmem_bio_merged = val & DA9063_BUCK_MERGE;