Browse Source

usb-misc: sisusbvga: Remove null test before calls to kfree()

This patch removes null test before calls to kfree() as kfree() can
handle null pointers safely.

Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Senna Tschudin 9 years ago
parent
commit
8a102fd6c9
1 changed files with 4 additions and 8 deletions
  1. 4 8
      drivers/usb/misc/sisusbvga/sisusb.c

+ 4 - 8
drivers/usb/misc/sisusbvga/sisusb.c

@@ -76,15 +76,11 @@ static void sisusb_free_buffers(struct sisusb_usb_data *sisusb)
 	int i;
 	int i;
 
 
 	for (i = 0; i < NUMOBUFS; i++) {
 	for (i = 0; i < NUMOBUFS; i++) {
-		if (sisusb->obuf[i]) {
-			kfree(sisusb->obuf[i]);
-			sisusb->obuf[i] = NULL;
-		}
-	}
-	if (sisusb->ibuf) {
-		kfree(sisusb->ibuf);
-		sisusb->ibuf = NULL;
+		kfree(sisusb->obuf[i]);
+		sisusb->obuf[i] = NULL;
 	}
 	}
+	kfree(sisusb->ibuf);
+	sisusb->ibuf = NULL;
 }
 }
 
 
 static void sisusb_free_urbs(struct sisusb_usb_data *sisusb)
 static void sisusb_free_urbs(struct sisusb_usb_data *sisusb)