Przeglądaj źródła

Blackfin: add some bounds checking to peripheral_request

The requested peripheral is turned into an index into some state arrays,
so make sure the calculated index doesn't exceed the index.  This occurs
when using bogus pin values or the define headers are screwed up.  Now
we'll notice right away that something needs fixing instead of trying to
track down random memory corruption.

Signed-off-by: Barry Song <barry.song@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Barry Song 16 lat temu
rodzic
commit
89e84eeace
1 zmienionych plików z 2 dodań i 0 usunięć
  1. 2 0
      arch/blackfin/kernel/bfin_gpio.c

+ 2 - 0
arch/blackfin/kernel/bfin_gpio.c

@@ -762,6 +762,8 @@ int peripheral_request(unsigned short per, const char *label)
 	if (!(per & P_DEFINED))
 	if (!(per & P_DEFINED))
 		return -ENODEV;
 		return -ENODEV;
 
 
+	BUG_ON(ident >= MAX_RESOURCES);
+
 	local_irq_save_hw(flags);
 	local_irq_save_hw(flags);
 
 
 	/* If a pin can be muxed as either GPIO or peripheral, make
 	/* If a pin can be muxed as either GPIO or peripheral, make