Преглед на файлове

orangefs: get rid of op->done

shouldn't be needed now

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Al Viro преди 9 години
родител
ревизия
897c5df6cf
променени са 4 файла, в които са добавени 2 реда и са изтрити 21 реда
  1. 0 13
      fs/orangefs/devorangefs-req.c
  2. 2 4
      fs/orangefs/file.c
  3. 0 2
      fs/orangefs/orangefs-cache.c
  4. 0 2
      fs/orangefs/orangefs-kernel.h

+ 0 - 13
fs/orangefs/devorangefs-req.c

@@ -424,19 +424,6 @@ wakeup:
 	 * application reading/writing this device to return until
 	 * the buffers are done being used.
 	 */
-	if (op->downcall.type == ORANGEFS_VFS_OP_FILE_IO) {
-		long n = wait_for_completion_interruptible_timeout(&op->done,
-							op_timeout_secs * HZ);
-		if (unlikely(n < 0)) {
-			gossip_debug(GOSSIP_DEV_DEBUG,
-				"%s: signal on I/O wait, aborting\n",
-				__func__);
-		} else if (unlikely(n == 0)) {
-			gossip_debug(GOSSIP_DEV_DEBUG,
-				"%s: timed out.\n",
-				__func__);
-		}
-	}
 out:
 	if (unlikely(op_is_cancel(op)))
 		put_cancel(op);

+ 2 - 4
fs/orangefs/file.c

@@ -199,7 +199,7 @@ populate_shared_memory:
 		if (orangefs_cancel_op_in_progress(new_op))
 			return ret;
 
-		goto done_copying;
+		goto out;
 	}
 
 	/*
@@ -212,7 +212,7 @@ populate_shared_memory:
 				       iter,
 				       new_op->downcall.resp.io.amt_complete);
 		if (ret < 0)
-			goto done_copying;
+			goto out;
 	}
 	gossip_debug(GOSSIP_FILE_DEBUG,
 	    "%s(%pU): Amount written as returned by the sys-io call:%d\n",
@@ -222,12 +222,10 @@ populate_shared_memory:
 
 	ret = new_op->downcall.resp.io.amt_complete;
 
-done_copying:
 	/*
 	 * tell the device file owner waiting on I/O that this read has
 	 * completed and it can return now.
 	 */
-	complete(&new_op->done);
 
 out:
 	if (buffer_index >= 0) {

+ 0 - 2
fs/orangefs/orangefs-cache.c

@@ -122,8 +122,6 @@ struct orangefs_kernel_op_s *op_alloc(__s32 type)
 
 		atomic_set(&new_op->ref_count, 1);
 
-		init_completion(&new_op->done);
-
 		new_op->upcall.type = ORANGEFS_VFS_OP_INVALID;
 		new_op->downcall.type = ORANGEFS_VFS_OP_INVALID;
 		new_op->downcall.status = -1;

+ 0 - 2
fs/orangefs/orangefs-kernel.h

@@ -205,8 +205,6 @@ struct orangefs_kernel_op_s {
 	struct completion waitq;
 	spinlock_t lock;
 
-	struct completion done;
-
 	atomic_t ref_count;
 
 	/* VFS aio fields */