Explorar o código

pcmcia: document return value of pcmcia_loop_config

Hopefully it will be harder to get it wrong now. Also fix an unneeded
initialization while we are here.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Wolfram Sang %!s(int64=16) %!d(string=hai) anos
pai
achega
889c27744c
Modificáronse 1 ficheiros con 2 adicións e 2 borrados
  1. 2 2
      drivers/pcmcia/pcmcia_resource.c

+ 2 - 2
drivers/pcmcia/pcmcia_resource.c

@@ -902,7 +902,7 @@ struct pcmcia_cfg_mem {
  *
  *
  * pcmcia_loop_config() loops over all configuration options, and calls
  * pcmcia_loop_config() loops over all configuration options, and calls
  * the driver-specific conf_check() for each one, checking whether
  * the driver-specific conf_check() for each one, checking whether
- * it is a valid one.
+ * it is a valid one. Returns 0 on success or errorcode otherwise.
  */
  */
 int pcmcia_loop_config(struct pcmcia_device *p_dev,
 int pcmcia_loop_config(struct pcmcia_device *p_dev,
 		       int	(*conf_check)	(struct pcmcia_device *p_dev,
 		       int	(*conf_check)	(struct pcmcia_device *p_dev,
@@ -915,7 +915,7 @@ int pcmcia_loop_config(struct pcmcia_device *p_dev,
 	struct pcmcia_cfg_mem *cfg_mem;
 	struct pcmcia_cfg_mem *cfg_mem;
 
 
 	tuple_t *tuple;
 	tuple_t *tuple;
-	int ret = -ENODEV;
+	int ret;
 	unsigned int vcc;
 	unsigned int vcc;
 
 
 	cfg_mem = kzalloc(sizeof(struct pcmcia_cfg_mem), GFP_KERNEL);
 	cfg_mem = kzalloc(sizeof(struct pcmcia_cfg_mem), GFP_KERNEL);