Преглед изворни кода

perf hists: Trim libtraceevent trace_seq buffers

When we use libtraceevent to format trace event fields into printable
strings to use in hist entries it is important to trim it from the
default 4 KiB it starts with to what is really used, to reduce the
memory footprint, so use realloc(seq.buffer, seq.len + 1) when returning
the seq.buffer formatted with the fields contents.

Reported-and-Tested-by: Wang Nan <wangnan0@huawei.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/n/tip-t3hl7uxmilrkigzmc90rlhk2@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Arnaldo Carvalho de Melo пре 9 година
родитељ
комит
887fa86d6f
1 измењених фајлова са 5 додато и 1 уклоњено
  1. 5 1
      tools/perf/util/sort.c

+ 5 - 1
tools/perf/util/sort.c

@@ -588,7 +588,11 @@ static char *get_trace_output(struct hist_entry *he)
 	} else {
 	} else {
 		pevent_event_info(&seq, evsel->tp_format, &rec);
 		pevent_event_info(&seq, evsel->tp_format, &rec);
 	}
 	}
-	return seq.buffer;
+	/*
+	 * Trim the buffer, it starts at 4KB and we're not going to
+	 * add anything more to this buffer.
+	 */
+	return realloc(seq.buffer, seq.len + 1);
 }
 }
 
 
 static int64_t
 static int64_t