Sfoglia il codice sorgente

fb: via: turn gpiolib and i2c selects into dependencies

Device driver should not directly select subsystems. In this case
we get build warnings like

warning: (ARCH_REQUIRE_GPIOLIB && PINCTRL_AT91 && PINCTRL_NOMADIK && MFD_TC6393XB && FB_VIA) selects GPIOLIB which has unmet direct dependencies (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB)

which we can avoid using the normal 'depends on' statement.

Also, this patch makes it possible for DRM drivers to have a dependency
on GPIOLIB without getting circular Kconfig dependencies.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Arnd Bergmann 11 anni fa
parent
commit
87f0fce775
1 ha cambiato i file con 1 aggiunte e 3 eliminazioni
  1. 1 3
      drivers/video/fbdev/Kconfig

+ 1 - 3
drivers/video/fbdev/Kconfig

@@ -1530,13 +1530,11 @@ config FB_SIS_315
 
 
 config FB_VIA
 config FB_VIA
        tristate "VIA UniChrome (Pro) and Chrome9 display support"
        tristate "VIA UniChrome (Pro) and Chrome9 display support"
-       depends on FB && PCI && X86
+       depends on FB && PCI && X86 && GPIOLIB && I2C
        select FB_CFB_FILLRECT
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        select FB_CFB_IMAGEBLIT
        select I2C_ALGOBIT
        select I2C_ALGOBIT
-       select I2C
-       select GPIOLIB
        help
        help
 	  This is the frame buffer device driver for Graphics chips of VIA
 	  This is the frame buffer device driver for Graphics chips of VIA
 	  UniChrome (Pro) Family (CLE266,PM800/CN400,P4M800CE/P4M800Pro/
 	  UniChrome (Pro) Family (CLE266,PM800/CN400,P4M800CE/P4M800Pro/