Просмотр исходного кода

efi: Small leak on error in runtime map code

The "> 0" here should ">= 0" so we free map_entries[0].

Fixes: 926172d46038 ('efi: Export EFI runtime memory mapping to sysfs')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Dan Carpenter 10 лет назад
Родитель
Сommit
86d68a58d0
1 измененных файлов с 1 добавлено и 1 удалено
  1. 1 1
      drivers/firmware/efi/runtime-map.c

+ 1 - 1
drivers/firmware/efi/runtime-map.c

@@ -191,7 +191,7 @@ int __init efi_runtime_map_init(struct kobject *efi_kobj)
 
 
 	return 0;
 	return 0;
 out_add_entry:
 out_add_entry:
-	for (j = i - 1; j > 0; j--) {
+	for (j = i - 1; j >= 0; j--) {
 		entry = *(map_entries + j);
 		entry = *(map_entries + j);
 		kobject_put(&entry->kobj);
 		kobject_put(&entry->kobj);
 	}
 	}