Преглед изворни кода

pinctrl: spmi-gpio: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
Cc: Björn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Linus Walleij пре 9 година
родитељ
комит
86c1a219c2
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

+ 1 - 1
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

@@ -533,7 +533,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned pin)
 		pad->out_value = ret & PMIC_MPP_REG_RT_STS_VAL_MASK;
 	}
 
-	return pad->out_value;
+	return !!pad->out_value;
 }
 
 static void pmic_gpio_set(struct gpio_chip *chip, unsigned pin, int value)