Browse Source

s390/topology: correct allocation of topology information

The data stored by the STSI instruction can be up to a page in size
but the memblock_virt_alloc allocation for tl_info only specifies
16 bytes. The memory after the short allocation is overwritten
every time arch_update_cpu_topology is called.

Fixes: 8c9105802235 "s390/numa: establish cpu to node mapping early"
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Martin Schwidefsky 8 years ago
parent
commit
8676caa4fb
1 changed files with 1 additions and 1 deletions
  1. 1 1
      arch/s390/kernel/topology.c

+ 1 - 1
arch/s390/kernel/topology.c

@@ -458,7 +458,7 @@ void __init topology_init_early(void)
 	set_sched_topology(s390_topology);
 	set_sched_topology(s390_topology);
 	if (!MACHINE_HAS_TOPOLOGY)
 	if (!MACHINE_HAS_TOPOLOGY)
 		goto out;
 		goto out;
-	tl_info = memblock_virt_alloc(sizeof(*tl_info), PAGE_SIZE);
+	tl_info = memblock_virt_alloc(PAGE_SIZE, PAGE_SIZE);
 	info = tl_info;
 	info = tl_info;
 	store_topology(info);
 	store_topology(info);
 	pr_info("The CPU configuration topology of the machine is: %d %d %d %d %d %d / %d\n",
 	pr_info("The CPU configuration topology of the machine is: %d %d %d %d %d %d / %d\n",