瀏覽代碼

ARM: pxa: Use kmalloc_array() in pxa_pm_init()

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Markus Elfring 9 年之前
父節點
當前提交
8571110575
共有 1 個文件被更改,包括 3 次插入2 次删除
  1. 3 2
      arch/arm/mach-pxa/pm.c

+ 3 - 2
arch/arm/mach-pxa/pm.c

@@ -104,8 +104,9 @@ static int __init pxa_pm_init(void)
 		return -EINVAL;
 		return -EINVAL;
 	}
 	}
 
 
-	sleep_save = kmalloc(pxa_cpu_pm_fns->save_count * sizeof(unsigned long),
-			     GFP_KERNEL);
+	sleep_save = kmalloc_array(pxa_cpu_pm_fns->save_count,
+				   sizeof(*sleep_save),
+				   GFP_KERNEL);
 	if (!sleep_save) {
 	if (!sleep_save) {
 		printk(KERN_ERR "failed to alloc memory for pm save\n");
 		printk(KERN_ERR "failed to alloc memory for pm save\n");
 		return -ENOMEM;
 		return -ENOMEM;