瀏覽代碼

ocfs2: fix SGID not inherited issue

Commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an
issue, SGID of sub dir was not inherited from its parents dir.  It is
because SGID is set into "inode->i_mode" in ocfs2_get_init_inode(), but
is overwritten by "mode" which don't have SGID set later.

Fixes: 8f1eb48758aa ("ocfs2: fix umask ignored issue")
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Acked-by: Srinivas Eeda <srinivas.eeda@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Junxiao Bi 9 年之前
父節點
當前提交
854ee2e944
共有 1 個文件被更改,包括 1 次插入3 次删除
  1. 1 3
      fs/ocfs2/namei.c

+ 1 - 3
fs/ocfs2/namei.c

@@ -367,13 +367,11 @@ static int ocfs2_mknod(struct inode *dir,
 		goto leave;
 		goto leave;
 	}
 	}
 
 
-	status = posix_acl_create(dir, &mode, &default_acl, &acl);
+	status = posix_acl_create(dir, &inode->i_mode, &default_acl, &acl);
 	if (status) {
 	if (status) {
 		mlog_errno(status);
 		mlog_errno(status);
 		goto leave;
 		goto leave;
 	}
 	}
-	/* update inode->i_mode after mask with "umask". */
-	inode->i_mode = mode;
 
 
 	handle = ocfs2_start_trans(osb, ocfs2_mknod_credits(osb->sb,
 	handle = ocfs2_start_trans(osb, ocfs2_mknod_credits(osb->sb,
 							    S_ISDIR(mode),
 							    S_ISDIR(mode),